Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking and fixing for RequiredAttribute in model classes #3051

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

deepchoudhery
Copy link
Member

Checking for [Required]/[RequiredAttribute`] and adding appropriate .cshtml/.razor for Create and Edit templates in both Razor Pages CRUD and Blazor CRUD (Razor Components w/ EF CRUD) scaffolders.

Copy link
Member

@tlmii tlmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and a suggestion or two, nothing earth-shattering. LGTM overall.

Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just a few formatting nits

@tlmii
Copy link
Member

tlmii commented Oct 29, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deepchoudhery deepchoudhery merged commit eedeb27 into main Oct 29, 2024
8 checks passed
@deepchoudhery deepchoudhery deleted the dev/decho/accessibility-crud-fixes branch October 29, 2024 18:13
@deepchoudhery
Copy link
Member Author

/backport to release/9.0

Copy link

Started backporting to release/9.0: https://github.com/dotnet/Scaffolding/actions/runs/11580148628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants