OpenXR bindings #228
Merged
OpenXR bindings #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HurricanKai
reviewed
Jul 14, 2020
Comment on lines
+39
to
+55
| catch | ||
| { | ||
| // do nothing | ||
| } | ||
| finally | ||
| { | ||
| if (ret == default) | ||
| { | ||
| throw new EntryPointNotFoundException | ||
| ( | ||
| $"Entry point \"{functionName}\" not found. Note that instance and device extensions must be " + | ||
| "enabled in order to load symbols correctly." | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| return ret; |
There was a problem hiding this comment.
What is the point of this?
Simply return in the try, and throw in the catch (possibly setting the caught exception as internal exception?)
Co-authored-by: HurricanKai <herrucan.schmitt@gmail.com>
|
Thanks! (will merge once ci has passed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds OpenXR bindings by reusing the Vulkan generator.
Related issues, Discord discussions, or proposals
#48
Closes #193
Further Comments
This also changes the OpenGL representation of strings to
byte*fromchar*by popular demand.