Fix Get methods
#30
Merged
Fix Get methods
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Entirely removed the get methods given they are only used twice |
|
I think we've already done this on the glfw-input branch actually on one of the more recent commits |
|
I pulled the glfw-input branch and edited it on that |
|
Ah ok, I thought I got them all! Will double check this and then merge it in. :) |
Perksey
approved these changes
Aug 1, 2019
Perksey
added a commit
that referenced
this pull request
Aug 4, 2019
* Start of the GLFW Input implementation * A start I guess, it's messy and all over the place * Additional work on GLFW input (#26) * Move ApplyDeadzone to Deadzone struct * Add test program, move ConnectionChanged to IInputContext * Add functionality to test program * More input work * Add an .editorconfig * ThumbstickCollection * ButtonCollection * Hat and Trigger collection * Update collections * joystick axis cache * Update cached axis * Update GlfwJoystick.cs * Joystick cache * AxisCollection * GamePad and Joystick cache * GamepadFix * GamePad Updates * Bracket fix * work * Thumbstick update * Gamepad implementation * nitpick * update test program * Update dispatcher * Only show window when running * Fix context not being passed to enumerator * Fix a marshalling bug * Apply deadzone * Enumerate over the disconnected joysticks too. * Update the test app. * Controller events fix * wip * Use indexers on the pointers * Fix mismatched enumerant names in GLFW * Destroy window when we're done * Fix wrong enum values in GLFW * Make properties update initialOptions, and only invoke GLFW if running * Window is immovable when only 1 thread is used, investigate WindowUpdate * Fix `Get` methods (#30) * Fix the abominations that were `Get()` methods * Remove Get methods entirely * Fully implement mice, fix deadlock issues * This is GLFW input. * Update GlfwInputContext.cs * Update Silk.NET.Input.Desktop.csproj * Update GlfwInputContext.cs * Update InputHandler.cs * Update GlfwInputContext.cs
silkdotnet
pushed a commit
that referenced
this pull request
Dec 25, 2022
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 25, 2022
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 25, 2022
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 25, 2022
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 25, 2022
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Dec 26, 2022
… Nov 16 23:37:59 UTC 2022
Beyley
pushed a commit
that referenced
this pull request
Jan 9, 2023
…ov 16 23:37:59 UTC 2022 (#1204) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
silkdotnet
pushed a commit
that referenced
this pull request
Jan 9, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 9, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 9, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 9, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 9, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
Beyley
pushed a commit
that referenced
this pull request
Jan 9, 2023
…ov 16 23:37:59 UTC 2022 (#1207) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
silkdotnet
pushed a commit
that referenced
this pull request
Jan 11, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 11, 2023
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 12, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 12, 2023
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 12, 2023
… Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 12, 2023
…SMP Wed Nov 16 23:37:59 UTC 2022
silkdotnet
pushed a commit
that referenced
this pull request
Jan 12, 2023
… Nov 16 23:37:59 UTC 2022
Beyley
pushed a commit
that referenced
this pull request
Jan 12, 2023
…ov 16 23:37:59 UTC 2022 (#1214) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Beyley
pushed a commit
that referenced
this pull request
Mar 12, 2023
…ov 16 23:37:59 UTC 2022 (#1204) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Beyley
pushed a commit
that referenced
this pull request
Mar 12, 2023
…ov 16 23:37:59 UTC 2022 (#1207) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Beyley
pushed a commit
that referenced
this pull request
Mar 12, 2023
…ov 16 23:37:59 UTC 2022 (#1214) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Beyley
pushed a commit
that referenced
this pull request
Mar 29, 2023
…ov 16 23:37:59 UTC 2022 (#1204) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Beyley
pushed a commit
that referenced
this pull request
Mar 29, 2023
…ov 16 23:37:59 UTC 2022 (#1207) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Beyley
pushed a commit
that referenced
this pull request
Mar 29, 2023
…ov 16 23:37:59 UTC 2022 (#1214) Co-authored-by: The Silk.NET Automaton <9011267+dotnet-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Fix the get methods to a) work properly and b) work nicely
Further Comments
These methods in themselves are abominations, and just a weird rewrite of indexing (
Get(p, 11)is exactly equivalent top[11]). Seems logical to remove them if not part of current public API