Skip to content

Use custom symbol loading #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 3, 2019
Merged

Use custom symbol loading #32

merged 10 commits into from
Aug 3, 2019

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Aug 3, 2019

Summary of the PR

  • Adds a GetProcAddress method to ISilkPlatform
  • Adds an IPlatformLoader which uses the ISilkPlatform to load symbols via ADL
  • Adds a SymbolLoaderName property to the profile JSON and bakery JSON.
  • Adds a static constructor to NativeAPIs
  • Refactors LibraryLoader to use multiple NativeLibraryBuilders.
  • Closes Use a custom symbol loader #22

Related issues, Discord discussions, or proposals

#22

Further Comments

ghost
ghost approved these changes Aug 3, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Well organized and structured changes.

@Perksey Perksey merged commit 0c8a5d5 into master Aug 3, 2019
@Perksey Perksey deleted the symbols branch August 3, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-OpenGL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use a custom symbol loader

1 participant

@Perksey