Skip to content

[2.0] NUKE and much-needed CI work #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 22, 2020
Merged

[2.0] NUKE and much-needed CI work #353

merged 15 commits into from
Nov 22, 2020

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Nov 21, 2020

Summary of the PR

A short summary of this PR and what it adds/removes/fixes.

Related issues, Discord discussions, or proposals

Links go here.

Further Comments

@Perksey Perksey requested a review from HurricanKai as a code owner November 22, 2020 15:33
@Perksey Perksey changed the title [WIP] [2.0] NUKE and much-needed CI work [2.0] NUKE and much-needed CI work Nov 22, 2020
@Perksey
Copy link
Member Author

Perksey commented Nov 22, 2020

@HurricanKai This is ready for review.

Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is BuildTools in this?
I'm assuming this works fine in IDE.

Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
@Perksey
Copy link
Member Author

Perksey commented Nov 22, 2020

BuildTools is used in the RegenerateBindings task, called by FullPack and FullPushToNuGet. The Full tasks aren't used by CI/CD because to ensure that builds are deterministic, I only want to build from the bindings already in the repo.

@Perksey Perksey merged commit 186149a into 2.0 Nov 22, 2020
@Perksey Perksey deleted the feature/nuke branch November 29, 2020 19:13
Perksey added a commit that referenced this pull request Mar 25, 2022
* Initial NUKE prototype

* First iteration of NUKE is done

* Add a test target

* Attempt one at updating the CI workflow

* Attempt two at CI

* Update global.json

* Update build.yml

* Update Silk.NET.NUKE.csproj

* Disable SilkTouch debug dump, checkout recursively

* Only test projects that have tests in the name

.NET insists on building everything again for some reason

* Stop deleting packages before pushing them

* Try adding Android in the loop

* Stop building libsilkdroid in CI (NDK issue)

* NUKE is complete

* Apply suggestions from code review

Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>

Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants