#651 Strong naming #655
#651 Strong naming #655
Conversation
|
Why only .NET 5+? From the documentation:
Per the documentation our .NET Standard TFMs are the only place where strong naming has meaning and is useful. More than happy to still let this in, but just wondering what the reason for this was. |
|
How does this interact with code signing? |
|
As long as the strong naming happens before code signing, it should be fine. AFAIK strong naming happens during compile, so the only times it should get tricky is if one is using delayed signing. |
| </AssemblyAttribute> | ||
| <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute"> | ||
| <_Parameter1>Silk.NET.Windowing.Sdl.Android</_Parameter1> | ||
| <_Parameter1>Silk.NET.Windowing.Sdl.Android, PublicKey=00240000048000009400000006020000002400005253413100040000010001003978b9c8ce5c08d54ff797be6fdcb734bb8f8fd47082de8d4311a2b85f89e9d27720824c2ca9b19bd6bdf54c583d297cf346d204b2d70826627789e6f536a7aa4f3e40f37f92ebeef91b820f1a61f15e9c0dccf3c2d372b5b4fa0c630f7cb6f18ea6aca8d04a4104d762f36f9b57ecbdde1055a16f5f088262b2df54c128debf</_Parameter1> |
There was a problem hiding this comment.
This assembly isn't strong named per your logic in common.props.
| @@ -10,10 +10,10 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute"> | |||
| <_Parameter1>Silk.NET.Input.Sdl</_Parameter1> | |||
| <_Parameter1>Silk.NET.Input.Sdl, PublicKey=00240000048000009400000006020000002400005253413100040000010001003978b9c8ce5c08d54ff797be6fdcb734bb8f8fd47082de8d4311a2b85f89e9d27720824c2ca9b19bd6bdf54c583d297cf346d204b2d70826627789e6f536a7aa4f3e40f37f92ebeef91b820f1a61f15e9c0dccf3c2d372b5b4fa0c630f7cb6f18ea6aca8d04a4104d762f36f9b57ecbdde1055a16f5f088262b2df54c128debf</_Parameter1> | |||
There was a problem hiding this comment.
What happens if Silk.NET.Input.Sdl isn't strong named? Is this just ignored?
|
OP has indicated this PR has been abandoned due to contribution friction: https://discord.com/channels/521092042781229087/587346162802229298/906165953878974494 Closing, but history will be preserved here so we can always pick up where you left off (you've signed the CLA). |
|
I've also added a note to our new tracker: https://github.com/orgs/dotnet/projects/64 |
Summary of the PR
Added strong naming for
net5.0+ TFMs. Configuration placed inbuild/props/common.propsat Kai's request.Related issues, Discord discussions, or proposals
#651
Further Comments
I have trouble building the whole solution, so it's difficult to say if the strong name is applied to the specific projects you folks want. I did spot check
Silk.NET.Mathsand it was strong named successfully for thenet5.0TFM.