Skip to content

Build improvements & dynamic Windows SDK resolution (backport from 3.0) #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 5, 2021
Merged

Build improvements & dynamic Windows SDK resolution (backport from 3.0) #661

merged 9 commits into from
Nov 5, 2021

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Oct 24, 2021 •
edited
Loading

@Perksey
Copy link
Member Author

Perksey commented Oct 24, 2021

Note: there are some slight differences, for instance #559 used Microsoft.Build.Locator which doesn't seem to work properly with VS22, whereas this uses the Visual Studio SDK directly. These changes will be incorporated into #559.

@Perksey Perksey requested a review from HurricanKai October 24, 2021 20:19
@Perksey Perksey added this to the 2.X milestone Oct 24, 2021
@Perksey
Copy link
Member Author

Perksey commented Oct 28, 2021 •
edited
Loading

TODO:

  • make anonymous native name renaming better

@Perksey
Copy link
Member Author

Perksey commented Nov 4, 2021

This is ready for review.

@Perksey Perksey mentioned this pull request Nov 5, 2021
Merged
11 tasks
@Perksey Perksey enabled auto-merge (squash) November 5, 2021 11:43
@Perksey Perksey disabled auto-merge November 5, 2021 11:43
@Perksey Perksey enabled auto-merge (squash) November 5, 2021 11:43
HurricanKai
HurricanKai approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed everything here, but it's largely autogenerated and they generally look good.

@Perksey Perksey merged commit 9fe05af into main Nov 5, 2021
@Perksey Perksey deleted the feature/buildtools-2.10 branch November 5, 2021 13:39
Perksey added a commit that referenced this pull request Mar 25, 2022
@Perksey
Build improvements, dynamic Windows SDK resolution, bugfixes (#661)
886c6b2 
* Build improvements & dynamic Windows SDK resolution (backport from 3.0)

* Changes to some code formatting

* Fix build errors

* Fix build error

* Enhanced typedef-powered renaming

* Fix #652

* Marshal generic pointers in COM vtable wrapper functions

* String generation improvements (fixes #630)

* Sanity check, remove JetBrains.Annotations
@HurricanKai HurricanKai mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HurricanKai HurricanKai HurricanKai approved these changes

Assignees
No one assigned
Labels
area-Core/Infrastructure/Codegen enhancement New feature or request
Projects
None yet
Milestone
2.X
Development

Successfully merging this pull request may close these issues.

[Linux] GLFW/SDL native library not loaded Incorrect string marshaling when "ID3D12Object::SetName" was called
2 participants
@Perksey @HurricanKai