SIMD for Silk.NET.Math #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HurricanKai
requested changes
Nov 3, 2021
Member
HurricanKai
left a comment
HurricanKai
left a comment
There was a problem hiding this comment.
Reviewed SSE for now - I think the review comments apply to the other ones as well so not reviewing the rest
Perksey
reviewed
Nov 3, 2021
Member
Perksey
left a comment
Perksey
left a comment
There was a problem hiding this comment.
Not codeowner, so these are just general things I noticed in passing: kai can decide whether to care.
Perksey
reviewed
Nov 3, 2021
WhiteBlackGoose
force-pushed
the
quackquack
branch
from
300f60c to
6d64e16
Compare
Relaxing type constraints for scalar bitwise operations
HurricanKai
requested changes
Nov 4, 2021
| @@ -0,0 +1,91 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
Member
There was a problem hiding this comment.
Just putting this here so I don't forget whether we went through with this change
HurricanKai
approved these changes
Nov 5, 2021
Member
HurricanKai
left a comment
HurricanKai
left a comment
There was a problem hiding this comment.
I approve and thank you for your huge contribution!
@Perksey please remove your X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Starting implementing the SIMD proposal.
Plan for this PR
All methods are for three bitnesses: 64, 128, 256.
CreateLoadAddSubtractMultiplyDivideAbsAndOrXorNotAllBitsSetIsHardwareAcceleratedOther: