-
-
Notifications
You must be signed in to change notification settings - Fork 432
This is the November 2021 Update (v2.10.0) #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perksey
commented
Nov 5, 2021
- Patch notes
- Rich NuGet readmes
- Rebranding
- Logo-in-package
- Configurable descriptions (paving the way for more and more specific package metadata)
Ready for review, but leaving as draft for now because
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. can you also give me a link to this new extended NuGet functionality?
build/props/common.props
Outdated
- Fix native libraries not being found in some cases for self-contained executables | ||
Silk.NET November 2021 Update | ||
|
||
- Added support for BigInteger and Complex in the Silk.NET.Maths.Scalar APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a thanks to @WhiteBlackGoose here? Feel like that'd be deserved, we've not done so in the past, but it'd be a nice gesture for the future if we start putting (#PR thank you @) from now on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
src/Maths/Directory.Build.props
Outdated
<Project> | ||
<PropertyGroup> | ||
<SilkDescription>A small and portable mathematics and linear algebra library, useful in graphics and compute workloads.</SilkDescription> | ||
<SilkExtendedDescription>This package has no other Silk.NET dependencies, so feel free to use it any project in any workload regardless of whether it uses other Silk.NET libraries or not. This is akin to System.Numerics.Vectors, only with extra types and generics (so any numerical type can be used rather than just float).</SilkExtendedDescription> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add something like "Supports Half, float, double, decimal, byte, sbyte, ushort, short, uint, int, ulong, long, Complex and BitInteger" just for posterity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Waiting for |
Logo-in-packagehttps://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5048 Readme functionalityhttps://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/ |
This has now been undrafted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would never review draft PRs
* Packaging improvements, NuGet readmes, and 2.10 release notes * Fix GitHub README rendering issues * Attempt to fix whitespace * push push push push push push push * Actually fix whitespace * Update common.props * Update Directory.Build.props
* Packaging improvements, NuGet readmes, and 2.10 release notes * Fix GitHub README rendering issues * Attempt to fix whitespace * push push push push push push push * Actually fix whitespace * Update common.props * Update Directory.Build.props
* Packaging improvements, NuGet readmes, and 2.10 release notes * Fix GitHub README rendering issues * Attempt to fix whitespace * push push push push push push push * Actually fix whitespace * Update common.props * Update Directory.Build.props