SIMD for Silk.NET.Math #3 #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteBlackGoose
commented
Nov 10, 2021
Comment on lines
-363
to
+365
| if (typeof(T) == typeof(int)) | ||
| if (typeof(T) == typeof(sbyte)) | ||
| { | ||
| return (int) (object) f < 0; | ||
| return (sbyte) (object) f < 0; |
Contributor
Author
There was a problem hiding this comment.
A bug from scalar
WhiteBlackGoose
commented
Nov 10, 2021
Contributor
Author
WhiteBlackGoose
left a comment
WhiteBlackGoose
left a comment
There was a problem hiding this comment.
There turns out a few bugs in scalar 🦆
| { | ||
| if (typeof(T) == typeof(float)) | ||
| { | ||
| return IsNormal((float) (object) f); |
Contributor
Author
There was a problem hiding this comment.
A bug from scalar
| { | ||
| if (typeof(T) == typeof(double)) | ||
| { | ||
| return IsNormal((double) (object) f); |
Contributor
Author
There was a problem hiding this comment.
and another bug from scalar
Contributor
Author
Benchmark reportsSilk.NET.Maths.Benchmark.SimdBenchmarks-asm.md Some methods are not inlined. Investigating... |
HurricanKai
approved these changes
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Working on #666
Tasks
IsFiniteIsInfinityIsNaNIsNegativeIsNegativeInfinityIsNormalIsPositiveInfinitySignTests
IsFiniteIsInfinityIsNaNIsNegativeIsNegativeInfinityIsNormalIsPositiveInfinitySignBenchmarks
State of number
IsFiniteIsInfinityIsNaNIsNegativeIsNegativeInfinityIsNormalIsPositiveInfinitySignOther