Skip to content

Make SharedContext settable #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Make SharedContext settable #829

merged 2 commits into from
Mar 12, 2022

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Mar 10, 2022

Summary of the PR

A short summary of this PR and what it adds/removes/fixes.

Related issues, Discord discussions, or proposals

Links go here.

Further Comments

@Perksey Perksey marked this pull request as ready for review March 12, 2022 19:29
@Perksey Perksey requested a review from a team as a code owner March 12, 2022 19:29
@Perksey
Copy link
Member Author

Perksey commented Mar 12, 2022

This is ready for review: 1 LOC change with a bit of generated fluff on top

@Perksey Perksey enabled auto-merge (squash) March 12, 2022 19:29
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't check whether this doesn't break anything - I feel like it will 👀
Have you tested this?

@Perksey Perksey merged commit bf3a2cb into main Mar 12, 2022
@Perksey Perksey deleted the hotfix/settable_context branch March 12, 2022 19:30
Perksey added a commit that referenced this pull request Mar 25, 2022
* Update WindowOptions.cs

* Declare API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants