Skip to content

Basic Emitter/Visitor docs #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2022
Merged

Basic Emitter/Visitor docs #892

merged 2 commits into from
Apr 19, 2022

Conversation

HurricanKai
Copy link
Member

(sorry forgot the branch prefix)

@HurricanKai HurricanKai requested a review from Perksey as a code owner April 18, 2022 22:40
@HurricanKai HurricanKai enabled auto-merge (squash) April 18, 2022 22:41
Perksey
Perksey requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with some code snippets and/or links back to the code.

@HurricanKai HurricanKai requested a review from Perksey April 19, 2022 11:12
Perksey
Perksey approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happiness

@HurricanKai HurricanKai merged commit 00d0225 into develop/3.0 Apr 19, 2022
@HurricanKai HurricanKai deleted the improve-emission-docs branch April 19, 2022 19:33
@HurricanKai HurricanKai mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HurricanKai @Perksey