-
Notifications
You must be signed in to change notification settings - Fork 286
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rework ExecuteReaderAsync to minimize allocations
- Loading branch information
Showing
8 changed files
with
366 additions
and
110 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AAsyncCallContext.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Microsoft.Data.SqlClient | ||
| { | ||
| // this class is a base class for creating derived objects that will store state for async operations | ||
| // avoiding the use of closures and allowing caching/reuse of the instances for frequently used async | ||
| // calls | ||
| // | ||
| // DO derive from this and seal and your class | ||
| // DO add additional fields or properties needed for the async operation and then override Clear to zero them | ||
| // DO override AfterClear and use the owner parameter to return the object to a cache location if you have one, this is the purpose of the method | ||
| // CONSIDER creating your own Set method that calls the base Set rather than providing a parameterized ctor, it is friendlier to caching | ||
| // DO NOT use this class after Dispose has been called. It will not throw ObjectDisposedException but it will be a cleared object | ||
|
|
||
| internal abstract class AAsyncCallContext<TOwner, TTask> : IDisposable | ||
| where TOwner : class | ||
| { | ||
| protected TOwner _owner; | ||
| protected TaskCompletionSource<TTask> _source; | ||
| protected IDisposable _disposable; | ||
|
|
||
| protected AAsyncCallContext() | ||
| { | ||
| } | ||
|
|
||
| protected AAsyncCallContext(TOwner owner, TaskCompletionSource<TTask> source, IDisposable disposable = null) | ||
| { | ||
| Set(owner, source, disposable); | ||
| } | ||
|
|
||
| protected void Set(TOwner owner, TaskCompletionSource<TTask> source, IDisposable disposable = null) | ||
| { | ||
| _owner = owner ?? throw new ArgumentNullException(nameof(owner)); | ||
| _source = source ?? throw new ArgumentNullException(nameof(source)); | ||
| _disposable = disposable; | ||
| } | ||
|
|
||
| protected void ClearCore() | ||
| { | ||
| _source = null; | ||
| _owner = default; | ||
| IDisposable copyDisposable = _disposable; | ||
| _disposable = null; | ||
| copyDisposable?.Dispose(); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// overrride this method to cleanup instance data before ClearCore is called which will blank the base data | ||
| /// </summary> | ||
| protected virtual void Clear() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// override this method to do work after the instance has been totally blanked, intended for cache return etc | ||
| /// </summary> | ||
| protected virtual void AfterCleared(TOwner owner) | ||
| { | ||
|
|
||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| TOwner owner = _owner; | ||
| try | ||
| { | ||
| Clear(); | ||
| } | ||
| finally | ||
| { | ||
| ClearCore(); | ||
| } | ||
| AfterCleared(owner); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.