Perf: Lazy init reconnect lock when needed (#379)

dotnet · Feb 5, 2020 · ce76eb0 · ce76eb0
1 parent c33ddd1
commit ce76eb0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
@@ -45,7 +45,7 @@ public sealed partial class SqlConnection : DbConnection, ICloneable
         private string _accessToken; // Access Token to be used for token based authententication
 
         // connection resiliency
-        private object _reconnectLock = new object();
+        private object _reconnectLock;
         internal Task _currentReconnectionTask;
         private Task _asyncWaitingForReconnection; // current async task waiting for reconnection in non-MARS connections
         private Guid _originalConnectionId = Guid.Empty;
@@ -1116,6 +1116,12 @@ internal Task ValidateAndReconnect(Action beforeDisconnect, int timeout)
                             if (cData._unrecoverableStatesCount == 0)
                             {
                                 bool callDisconnect = false;
+
+                                if (_reconnectLock is null)
+                                {
+                                    Interlocked.CompareExchange(ref _reconnectLock, new object(), null);
+                                }
+
                                 lock (_reconnectLock)
                                 {
                                     tdsConn.CheckEnlistedTransactionBinding();