moving from Functional to Manual Tests

dotnet · Feb 4, 2020 · f39321c · f39321c
1 parent c3a27a4
commit f39321c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...nctionalTests/SqlClientEventSourceTest.cs → ...s/EventSource/SqlClientEventSourceTest.cs b/...nctionalTests/SqlClientEventSourceTest.cs → ...s/EventSource/SqlClientEventSourceTest.cs
@@ -4,20 +4,22 @@
 
 using System.Collections.Generic;
 using System.Diagnostics.Tracing;
+using Microsoft.Data.SqlClient.ManualTesting.Tests;
 using Xunit;
 
 namespace Microsoft.Data.SqlClient.Tests
 {
-    [SkipOnTargetFramework(TargetFrameworkMonikers.Netcoreapp,"Not Implemented")]
+    [SkipOnTargetFramework(TargetFrameworkMonikers.Netcoreapp, "Not Implemented")]
     public class SqlClientEventSourceTest
     {
-        [Fact]
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
         public void IsTraceEnabled()
         {
+            string connString = DataTestUtility.TCPConnectionString;
             using (var listener = new SampleEventListener())
             {
                 listener.EnableEvents(SqlClientEventSource.Log, EventLevel.Informational, SqlClientEventSource.Keywords.Trace);
-                using (SqlConnection connection = new SqlConnection("Data Source=tcp:localhost;Database=Northwind;Integrated Security=true;"))
+                using (SqlConnection connection = new SqlConnection(connString))
                 {
                     connection.Open();
                     using (SqlCommand command = new SqlCommand("SELECT * From [Customers]", connection))

diff --git a/...soft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj b/...soft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
@@ -56,6 +56,7 @@
     <Compile Include="AlwaysEncrypted\TestTrustedMasterKeyPaths.cs" />
     <Compile Include="DataCommon\AADUtility.cs" />
     <Compile Include="DataCommon\CheckConnStrSetupFactAttribute.cs" />
+    <Compile Condition="'$(TargetGroup)'=='netfx'" Include="EventSource\SqlClientEventSourceTest.cs" />
     <Compile Include="SQL\AdapterTest\AdapterTest.cs" />
     <Compile Include="SQL\AsyncTest\BeginExecAsyncTest.cs" />
     <Compile Include="SQL\AsyncTest\BeginExecReaderAsyncTest.cs" />