-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Azure Identity support - Phase 1 changes #1010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
force-pushed
the
azureIdentity
branch
from
March 25, 2021 20:31
f8abb46
to
5781106
Compare
cheenamalhotra
added
🆕 Public API
Issues/PRs that introduce new APIs to the driver.
🔨 Breaking Change
Issues/PRs that are related with breaking API changes in the driver.
labels
Mar 25, 2021
...lClient/netcore/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.NetStandard.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Apr 13, 2021
...soft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Apr 14, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
Show resolved
Hide resolved
johnnypham
reviewed
Apr 14, 2021
doc/snippets/Microsoft.Data.SqlClient/SqlAuthenticationParameters.xml
Outdated
Show resolved
Hide resolved
johnnypham
approved these changes
Apr 14, 2021
JRahnama
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 Breaking Change
Issues/PRs that are related with breaking API changes in the driver.
🆕 Public API
Issues/PRs that introduce new APIs to the driver.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 1 changes
ManagedIdentityCredential()
for Managed Identity based authentication modes (ActiveDirectoryMSI
andActiveDirectoryManagedIdentity
)ManagedIdentityCredential()
ManagedIdentityCredential()
ClientSecretCredential()
SqlConnection
property toSqlAuthenticationParameters
to provide cancellation token to all Async calls in order to cancel token acquire request after "timeout" milliseconds.Public Observations:
SqlAuthenticationParameters.ConnectionTimeout