Change WeakReference to WeakReference<T> #1122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading #1121 I remembered that we're using
WeakReference
and notWeakReference<T>
, the generic version has a different api shape usingbool isAlive = TryGetTarget(out T target)
to prevent the possibility of a GC betweenIsAlive
andTarget
property accesses. Note thatTryGetTarget
returns false for null which is why some null checks are no longer needed.