Simplify managed SNI receive callback use #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
➕ Code Health
Wraith2
force-pushed
the
sni-simplifycallbacks
branch
from
bf79179
to
6d49b49
Compare
DavoudEshtehari
requested review from
JRahnama,
johnnypham,
DavoudEshtehari and
Kaur-Parminder
Wraith2
force-pushed
the
sni-simplifycallbacks
branch
from
5d6e3db
to
4c73ea5
Compare
|
Freshly rebased and the real CI is green, all ready to go. |
DavoudEshtehari
requested review from
David-Engel
and removed request for
johnnypham
DavoudEshtehari
approved these changes
May 20, 2022
|
Usings cleaned up in the files mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated why there seem to be two ways to set the callbacks which are executed on async reads and writes to packets. It looks like the original method was to pass the callback as a parameter to the function and then later because of the need to support MARS there needed to be a way to store set the callback before that call so it could override the parameter which was made nullable.
This PR removes the ability to pass the callback as part of the call and requires that it always be set by calling SetReceiveCallback. Doing this removes the need to pass the callback as the state parameter to the async call meaning that the packet can be used as state instead which allows the callback to be static because everything needed to finish the call is now part of the packet itself.