Fix regression in CancelAsyncConnections test using Native SNI #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. Seems reasonable. I noted this location in the original PR as a point of interest. |
DavoudEshtehari
approved these changes
Aug 25, 2021
JRahnama
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in PR #933 caused
CancelAsyncConnectionstest to fail for Native SNI. Using Debug configuration locally helped reproduce the failing assertion consistently. This test did not fail in public CI pipelines but it failed today in our internal build, which is surprising and we're looking into it.@Wraith2
I'm patching the packet release code block to be applicable to only Managed SNI so we can proceed to release, but it should be investigated in Managed SNI layer as there are many debug assertion failures that indicate towards design issues when running the
CancelAsyncConnectionstest.