Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move into shared for SqlCachedBuffer.cs #1280

Merged
merged 10 commits into from
Oct 8, 2021
Merged

Move into shared for SqlCachedBuffer.cs #1280

merged 10 commits into from
Oct 8, 2021

Commits on Sep 23, 2021

  1. Move the netcore version of SqlCachedBuffer to src and update referen… 

    …ce in netfx csproj
    @lcheunglci
    lcheunglci committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    0a7d82e View commit details
    Browse the repository at this point in the history

  2. Update the code to conform with the coding style

    @lcheunglci
    lcheunglci committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    a183f01 View commit details
    Browse the repository at this point in the history

  3. Update the get accessor to expression body definition

    @lcheunglci
    lcheunglci committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7520331 View commit details
    Browse the repository at this point in the history

  4. Remove ToXmlReader because it's not referenced anywhere on both netfx… 

    … and netcore and it's internal
    @lcheunglci
    lcheunglci committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    986fe1c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Merge branch 'dotnet:main' into MergeShared-SqlCachedBuffer

    @lcheunglci
    lcheunglci authored Sep 28, 2021
    Configuration menu
    Copy the full SHA
    500c4a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Merge branch 'dotnet:main' into MergeShared-SqlCachedBuffer

    @lcheunglci
    lcheunglci authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    7dd8488 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Apply suggestions from code review 

    Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
    @lcheunglci @DavoudEshtehari
    lcheunglci and DavoudEshtehari authored Oct 5, 2021
    Configuration menu
    Copy the full SHA
    fac9f00 View commit details
    Browse the repository at this point in the history

  2. Revised the expression bodied getter and spacing based on the comments

    @lcheunglci
    lcheunglci committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    65f6488 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Resolve merge conflict

    @lcheunglci
    lcheunglci committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    043764b View commit details
    Browse the repository at this point in the history

  2. Fix compiler error due to redefinition of IsNull

    @lcheunglci
    lcheunglci committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    ee8f9f2 View commit details
    Browse the repository at this point in the history