Fixes FormatException when Tracing is enabled #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
approved these changes
Sep 27, 2021
|
Perhaps there need to be some tests run with tracing enabled. |
|
The use case is related to refreshing access token before expiry which will be a long wait in test suite. |
|
Ok, making the tests take even longer isn't a good idea. |
JRahnama
approved these changes
Sep 29, 2021
|
@JRahnama can you port this fix to 3.1-servicing so we could potentially pick it up if there's another SSMS 19.x release? |
|
@shueybubbles I will add this to our list. |
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug #1290 by simply removing the redundant argument from the overload.