-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to shared - SmiMetaDataProperty #1320
Move to shared - SmiMetaDataProperty #1320
Conversation
This is part of dotnet#1261 Code Merge effort. Moved the file to common src folder. The Netfx and Netcore files were same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some opportunities for code improvement in this file. Could you check the suggested changes by VS?
applied changes suggested by Visual Studio
I have added the VS suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavoudEshtehari Just Addressed those changes. Thanks. |
This is part of #1261 Code Merge effort. Moved the file to common src folder. The Netfx and Netcore files were same.