Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Shared for SqlConnectionPoolGroupProviderInfo.cs #1323

Merged
merged 8 commits into from
Oct 13, 2021
Merged

Move to Shared for SqlConnectionPoolGroupProviderInfo.cs #1323

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abb3e02
Merge netfx into netcore for SqlConnectionPoolGroupProviderInfo.cs
lcheunglci Oct 6, 2021
e7cf98e
Move netcore version of SqlConnectionPoolGroupProviderInfo.cs into sh…
lcheunglci Oct 6, 2021
6ef2843
Resolve merge conflict with the csprojs
lcheunglci Oct 6, 2021
55771db
Apply suggestions from code review
lcheunglci Oct 8, 2021
f9a7c94
Fix compiler error after code revision due to missing namespace
lcheunglci Oct 8, 2021
cb81371
Update properties to use expression bodies and remove the namespace o…
lcheunglci Oct 8, 2021
9fa041d
Apply suggestion to remove the ifdef for the System.Security namespace
lcheunglci Oct 8, 2021
89dfc6e
Remove the InternalConnection parameter in FailoverCheck method becau…
lcheunglci Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionPoolGroupProviderInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#if NETFRAMEWORK
using System.Security;
#endif
lcheunglci marked this conversation as resolved.
Show resolved Hide resolved
using Microsoft.Data.ProviderBase;

namespace Microsoft.Data.SqlClient
Expand Down