-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Shared - SqlTransaction #1353
Move to Shared - SqlTransaction #1353
Conversation
SNI Update
This reverts commit 7aebf45.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the SqlTransaction.netcore
and SqlTransaction.netfx
files back into their project's hierarchy?
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.netfx.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.netfx.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.netcore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.netfx.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.netfx.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlTransaction.cs
Outdated
Show resolved
Hide resolved
review suggestions Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
- Coverage 71.40% 71.28% -0.13%
==========================================
Files 295 296 +1
Lines 61195 61161 -34
==========================================
- Hits 43697 43598 -99
- Misses 17498 17563 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
addressing comment
review comments
SqlTransaction -> SqlTransaction.Common (renamed) SqlTransaction.netfx -> SqlTransaction (under netfx project hierarchy) SqlTransaction.netcore -> SqlTransaction (under netcore project hierarchy)
This is part of #1261 Code merge effort. Move the common code to shared folder and to avoid complicated if defs just kept major feature commit, save, rollback in netcore and netfx files.