Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Shared - SqlTransaction #1353

Merged
merged 22 commits into from
Jun 9, 2022

Conversation

Kaur-Parminder
Copy link
Contributor

@Kaur-Parminder Kaur-Parminder commented Oct 18, 2021

This is part of #1261 Code merge effort. Move the common code to shared folder and to avoid complicated if defs just kept major feature commit, save, rollback in netcore and netfx files.

@Kaur-Parminder Kaur-Parminder added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Oct 18, 2021
@Kaur-Parminder Kaur-Parminder added this to the 4.0.0-preview3 milestone Oct 18, 2021
@cheenamalhotra cheenamalhotra removed this from the 4.0.0-preview3 milestone Oct 19, 2021
@JRahnama JRahnama added this to the 5.0.0-preview1 milestone Dec 7, 2021
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the SqlTransaction.netcore and SqlTransaction.netfx files back into their project's hierarchy?

Kaur-Parminder and others added 3 commits June 6, 2022 17:06
review suggestions

Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1353 (2f9cfdd) into main (9b1996a) will decrease coverage by 0.12%.
The diff coverage is 73.17%.

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
- Coverage   71.40%   71.28%   -0.13%     
==========================================
  Files         295      296       +1     
  Lines       61195    61161      -34     
==========================================
- Hits        43697    43598      -99     
- Misses      17498    17563      +65     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.77% <75.00%> (-0.19%) ⬇️
netfx 69.17% <72.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tfx/src/Microsoft/Data/SqlClient/SqlTransaction.cs 55.20% <0.00%> (-3.19%) ⬇️
.../Microsoft/Data/SqlClient/SqlTransaction.Common.cs 74.35% <74.35%> (ø)
...ore/src/Microsoft/Data/SqlClient/SqlTransaction.cs 90.00% <100.00%> (+6.19%) ⬆️
...src/Microsoft/Data/SqlClient/SqlMetadataFactory.cs 81.66% <0.00%> (-10.84%) ⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs 56.81% <0.00%> (-6.82%) ⬇️
...rc/Microsoft/Data/SqlClient/SQLFallbackDNSCache.cs 90.62% <0.00%> (-6.25%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.29% <0.00%> (-5.12%) ⬇️
...soft/Data/SqlClient/TdsParserStateObjectManaged.cs 83.91% <0.00%> (-3.01%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 59.01% <0.00%> (-2.46%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.24% <0.00%> (-0.73%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1996a...2f9cfdd. Read the comment docs.

Kaur-Parminder and others added 3 commits June 8, 2022 08:01
addressing comment
review comments
SqlTransaction -> SqlTransaction.Common (renamed)
SqlTransaction.netfx -> SqlTransaction (under netfx project hierarchy)
SqlTransaction.netcore -> SqlTransaction (under netcore project hierarchy)
@DavoudEshtehari DavoudEshtehari merged commit 966fc6e into dotnet:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants