Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved to Shared - SqlParameter #1354

Merged
merged 15 commits into from
Jun 3, 2022

Conversation

Kaur-Parminder
Copy link
Contributor

This is part of #1261 code merge effort. Moved the file to common folder. added some code style changes and updated Resource strings.

@Kaur-Parminder Kaur-Parminder added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Oct 18, 2021
@Kaur-Parminder Kaur-Parminder added this to the 4.0.0-preview3 milestone Oct 18, 2021
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1354 (784dc00) into main (845902c) will increase coverage by 5.77%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   65.47%   71.24%   +5.77%     
==========================================
  Files         295      294       -1     
  Lines       62125    61174     -951     
==========================================
+ Hits        40678    43586    +2908     
+ Misses      21447    17588    -3859     
Flag Coverage Δ
addons 92.38% <ø> (+92.38%) ⬆️
netcore 74.76% <83.33%> (+5.75%) ⬆️
netfx 69.18% <84.21%> (+5.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a.SqlClient/netcore/src/Resources/StringsHelper.cs 0.00% <ø> (-26.67%) ⬇️
...lient/src/Microsoft/Data/SqlClient/SqlParameter.cs 75.50% <82.35%> (ø)
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 72.47% <100.00%> (+19.38%) ⬆️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-11.61%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.18% <0.00%> (-5.12%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 71.42% <0.00%> (-3.58%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845902c...784dc00. Read the comment docs.

@DavoudEshtehari DavoudEshtehari merged commit d0c5c26 into dotnet:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants