-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved to Shared - SqlParameter #1354
Merged
DavoudEshtehari
merged 15 commits into
dotnet:main
from
Kaur-Parminder:CodeMergeSqlParameter
Jun 3, 2022
Merged
Moved to Shared - SqlParameter #1354
DavoudEshtehari
merged 15 commits into
dotnet:main
from
Kaur-Parminder:CodeMergeSqlParameter
Jun 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaur-Parminder
added
the
➕ Code Health
Issues/PRs that are targeted to source code quality improvements.
label
Oct 18, 2021
Wraith2
suggested changes
Oct 18, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameter.cs
Outdated
Show resolved
Hide resolved
SNI Update
This reverts commit 7aebf45.
johnnypham
approved these changes
Apr 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 65.47% 71.24% +5.77%
==========================================
Files 295 294 -1
Lines 62125 61174 -951
==========================================
+ Hits 40678 43586 +2908
+ Misses 21447 17588 -3859
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
David-Engel
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1261 code merge effort. Moved the file to common folder. added some code style changes and updated Resource strings.