-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not check IsUsingManagedSNI in NonAzureNoProtocolConnectionTestWindows for netfx #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 68.72% 68.69% -0.04%
==========================================
Files 332 332
Lines 66506 66506
==========================================
- Hits 45703 45683 -20
- Misses 20803 20823 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
DavoudEshtehari
approved these changes
Nov 29, 2021
DavoudEshtehari
added
Area\Tests
Issues that are targeted to tests or test projects
Area\Netfx
Issues that are apply only to .NET Framework or the 'netfx' project folder.
labels
Nov 29, 2021
JRahnama
approved these changes
Nov 29, 2021
Kaur-Parminder
added a commit
to Kaur-Parminder/SqlClient
that referenced
this pull request
Mar 1, 2022
…dows for netfx dotnet#1410 Do not check IsUsingManagedSNI in NonAzureNoProtocolConnectionTestWindows for netfx dotnet#1410
Kaur-Parminder
added a commit
to Kaur-Parminder/SqlClient
that referenced
this pull request
Mar 2, 2022
…dows for netfx dotnet#1410 Do not check IsUsingManagedSNI in NonAzureNoProtocolConnectionTestWindows for netfx dotnet#1410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area\Netfx
Issues that are apply only to .NET Framework or the 'netfx' project folder.
Area\Tests
Issues that are targeted to tests or test projects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new CI setup we're testing, to reduce build times we've grouped together netcore and netfx tests in single jobs. As a result, this test was failing when
UseManagedSNIOnWindows
istrue
in config.json.