Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check IsUsingManagedSNI in NonAzureNoProtocolConnectionTestWindows for netfx #1410

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

johnnypham
Copy link
Contributor

In the new CI setup we're testing, to reduce build times we've grouped together netcore and netfx tests in single jobs. As a result, this test was failing when UseManagedSNIOnWindows is true in config.json.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1410 (ce21aba) into main (78676d6) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   68.72%   68.69%   -0.04%     
==========================================
  Files         332      332              
  Lines       66506    66506              
==========================================
- Hits        45703    45683      -20     
- Misses      20803    20823      +20     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 71.17% <ø> (-0.08%) ⬇️
netfx 67.81% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 41.96% <0.00%> (-9.83%) ⬇️
...Client/Reliability/Common/SqlRetryLogicProvider.cs 89.13% <0.00%> (-2.18%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.35% <0.00%> (-0.70%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.61% <0.00%> (-0.51%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.48% <0.00%> (-0.45%) ⬇️
...nt/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs 49.60% <0.00%> (-0.32%) ⬇️
...ient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs 58.85% <0.00%> (-0.25%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.26% <0.00%> (-0.22%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.00% <0.00%> (-0.17%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.48% <0.00%> (-0.03%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78676d6...ce21aba. Read the comment docs.

@DavoudEshtehari DavoudEshtehari added Area\Tests Issues that are targeted to tests or test projects Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. labels Nov 29, 2021
@johnnypham johnnypham merged commit c56baaa into dotnet:main Nov 29, 2021
@johnnypham johnnypham deleted the 1esfailure branch December 2, 2021 20:27
Kaur-Parminder added a commit to Kaur-Parminder/SqlClient that referenced this pull request Mar 1, 2022
…dows for netfx dotnet#1410

Do not check IsUsingManagedSNI in NonAzureNoProtocolConnectionTestWindows for netfx dotnet#1410
Kaur-Parminder added a commit to Kaur-Parminder/SqlClient that referenced this pull request Mar 2, 2022
…dows for netfx dotnet#1410

Do not check IsUsingManagedSNI in NonAzureNoProtocolConnectionTestWindows for netfx dotnet#1410
DavoudEshtehari pushed a commit that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants