Suppress TLS security warning with Encrypt=false by new AppContext switch #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
requested review from
johnnypham,
David-Engel,
JRahnama and
Kaur-Parminder
JRahnama
reviewed
Jan 7, 2022
David-Engel
reviewed
Jan 7, 2022
David-Engel
approved these changes
Jan 10, 2022
JRahnama
approved these changes
Jan 10, 2022
Kaur-Parminder
approved these changes
Jan 11, 2022
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Jan 13, 2022
…itch (dotnet#1457) # Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1434
When connecting to a server, if a protocol lower than TLS 1.2 is negotiated, a security warning is output to the console. This warning can be suppressed on SQL connections with
Encrypt = falseby enabling the following AppContext switch on application startup:Switch.Microsoft.Data.SqlClient.SuppressInsecureTLSWarning