Test | Add lock when using ClearSqlConnectionGlobalProviders #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnypham
commented
Jan 11, 2022
| /// <summary> | ||
| /// SetCustomColumnEncryptionKeyStoreProvider can be called only once in a process. To workaround that, we use this flag. | ||
| /// </summary> | ||
| private static bool s_testCustomEncryptioKeyStoreProviderExecutedOnce = false; |
There was a problem hiding this comment.
This field was never even changed anywhere.
DavoudEshtehari
added
the
Area\Tests
DavoudEshtehari
changed the title
DavoudEshtehari
approved these changes
Jan 13, 2022
Kaur-Parminder
approved these changes
Jan 13, 2022
JRahnama
approved these changes
Jan 14, 2022
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 20, 2022
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 22, 2022
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 22, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Aug 30, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s_globalCustomColumnEncryptionKeyStoreProviderscan only be set once usingSqlConnection.RegisterColumnEncryptionKeyStoreProviders(). It has to be cleared after any test sets it, so that other tests can set it again. Because the functional tests run in parallel, we sometimes see aKey store providers cannot be set more than once.error. We can add a lock to ensure only one test at a time is setting and clearings_globalCustomColumnEncryptionKeyStoreProviders.Repro:
https://github.com/johnnypham/SqlClient/tree/testfailurerepro
Run the two tests with the appropriate filter: