-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix populating of TYPE_SCHEMA column in StructuredTypeMembers metadata #1500
Conversation
Looks good in general. The nuget comes from the package source in the nuget.config file in the src directory, everything below that directory should pick it up. I can run tests locally but I've been doing it for a while so if something has broken I might already have the nuget packages locally. Specifically which packages failed to restore? |
@Wraith2: Microsoft.Data.SqlClient.ManualTesting.Test is reporting that Microsoft.DotNet.RemoteExecutor (5.0.0-beta.20206.4) is not available in the dotnet-public package source. |
I don't have that package locally and I haven't had that problem (but then i haven't opened any PR's in a while since I.m waiting.). Remote executor is needed for tests that are going to run in the ci as an external process so you may not need it to check your work locally. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 65.47% 71.41% +5.93%
==========================================
Files 295 295
Lines 62125 62126 +1
==========================================
+ Hits 40678 44368 +3690
+ Misses 21447 17758 -3689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fixes for #1498
I was unable to run the tests as I don't have access to a required nuget package in test project.