-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge common code bases for TdsParserStateObject.cs #1520
Merged
Merged
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
22c25f5
Merging common fields, properties and types of TdsParserStateObject.
panoskj 4ec17f6
Merging common type NullBitmap of TdsParserStateObject.
panoskj de83b8d
Merging a few methods of TdsParserStateObject.
panoskj d15a7d3
Merging constructor of TdsParserStateObject.
panoskj 927e4a6
Merging some methods of TdsParserStateObject.
panoskj 2c81d54
Merging ObjectID property of TdsParserStateObject.
panoskj 72d8e54
Merge remote-tracking branch 'upstream/main' into MergeTdsParserState…
DavoudEshtehari 417a6da
Merging some methods of TdsParserStateObject (note: ports part of #10…
panoskj b8eb31d
Merging some methods of TdsParserStateObject (note: uses some #if dir…
panoskj c145b8d
Merge branch 'main' into MergeTdsParserStateObject
panoskj ed279eb
Merge branch 'main' into MergeTdsParserStateObject
panoskj 4e6ed9a
TdsParserStateObject: Fixed naming rules violations.
panoskj 315acb1
TdsParserStateObject: Removed unnecessary assignments. Used discard t…
panoskj 87f0cba
TdsParserStateObject: Simplified names.
panoskj d71028b
TdsParserStateObject: Simplified default expression.
panoskj 3e05aeb
TdsParserStateObject: Removed unnecessary casts.
panoskj 58ae136
TdsParserStateObject: Replaced var usages with explicit types.
panoskj 5eb4a61
Apply suggestions from code review
DavoudEshtehari f75d911
Merge remote-tracking branch 'upstream/main' into MergeTdsParserState…
DavoudEshtehari 0b4c345
Address comments
DavoudEshtehari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,100 changes: 51 additions & 1,049 deletions
1,100
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,129 changes: 83 additions & 1,046 deletions
1,129
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try using explicit type instead of var please.