-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge to shared - TdsParserSafeHandles #1604
Merge to shared - TdsParserSafeHandles #1604
Conversation
…lete the netfx one and update project references
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserSafeHandles.cs
Outdated
Show resolved
Hide resolved
timeout = Timeout.Infinite; // -1 == native SNIOPEN_TIMEOUT_VALUE / INFINITE | ||
} | ||
|
||
#if NETFRAMEWORK | ||
int transparentNetworkResolutionStateNo = (int)transparentNetworkResolutionState; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the plans are for transparent network resolution. It may be a feature that should come to netcore eventually. It might be an idea to have a new compiler constant for it, @David-Engel is probably the person who would know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current sentiment around TNIR is that we can bring connection string and SqlConnectionStringBuilder parity to netcore but we should not actually implement the TNIR logic. Apparently it caused more support issues than it solved for Azure. Customers that really need the driver to initiate parallel connection attempts against each IP DNS resolves to should use MSF.
…eHandles only exist on windows
Thanks for the review @Wraith2 and I made the revisions. I noticed that there were some compiler errors on Linux because this file was meant for windows only and I placed it in the common ItemGroup. I also noticed that some existing files have the .windows suffix, not sure if I should add the windows suffix to this to keep it consistent. |
If it's windows specific then please add the .windows.cs suffix. |
Codecov Report
@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 71.54% 71.38% -0.17%
==========================================
Files 291 290 -1
Lines 61241 61147 -94
==========================================
- Hits 43817 43651 -166
- Misses 17424 17496 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Relates to #1261. Merged netfx into netcore for TdsParserSafeHandles, and moving it to shared src and update the project references.