Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Add support server SPN option #1607

Merged
merged 17 commits into from
Jun 16, 2022

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari commented May 6, 2022

Skip the driver-generated SPN in case of providing Server SPN and Failover Partner SPN options in a connection string.

link: Service Principal Names

@DavoudEshtehari DavoudEshtehari added Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. labels May 6, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.0.0-preview3 milestone May 6, 2022
@DavoudEshtehari DavoudEshtehari changed the title WIP | Feature | Add support server SPN in connection string Feature | Add support server SPN option May 16, 2022
@DavoudEshtehari DavoudEshtehari marked this pull request as ready for review May 16, 2022 19:57
# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionTest.cs
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1607 (cba974c) into main (d600f89) will decrease coverage by 1.99%.
The diff coverage is 73.01%.

❗ Current head cba974c differs from pull request most recent head 8b026b3. Consider uploading reports for the commit 8b026b3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   71.40%   69.40%   -2.00%     
==========================================
  Files         290      291       +1     
  Lines       61048    61241     +193     
==========================================
- Hits        43589    42507    -1082     
- Misses      17459    18734    +1275     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 72.98% <79.92%> (-1.99%) ⬇️
netfx 67.08% <71.87%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Microsoft/Data/SqlClient/SNI/SNIPhysicalHandle.cs 100.00% <ø> (ø)
...a.SqlClient/netcore/src/Resources/StringsHelper.cs 26.66% <ø> (ø)
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 93.29% <ø> (+0.60%) ⬆️
...core/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs 40.00% <15.38%> (-47.50%) ⬇️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 69.76% <50.00%> (-1.22%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.03% <66.66%> (-0.78%) ⬇️
.../Microsoft/Data/Common/DbConnectionStringCommon.cs 64.05% <66.66%> (+0.05%) ⬆️
...rc/Microsoft/Data/SqlClient/SqlConnectionString.cs 71.99% <66.66%> (-0.56%) ⬇️
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs 85.02% <69.23%> (-1.50%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 66.75% <82.60%> (-0.85%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778f86e...8b026b3. Read the comment docs.

# Conflicts:
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.resx
# Conflicts:
#	doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
#	src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionString.cs
#	src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs
@DavoudEshtehari DavoudEshtehari merged commit 04db1a4 into dotnet:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants