Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Handle NRE on Azure federated authentication #1625

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

DavoudEshtehari
Copy link
Member

@DavoudEshtehari DavoudEshtehari commented May 26, 2022

Applications owned and operated by Microsoft must get approval from the API owner before requesting tokens for that API, otherwise, the token won't be resolved.

@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label May 26, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.0.0-preview3 milestone May 26, 2022
@DavoudEshtehari DavoudEshtehari marked this pull request as ready for review May 26, 2022 16:24
@DavoudEshtehari DavoudEshtehari changed the title Fix | Handle NRE on federated authentication on Azure Fix | Handle NRE on Azure federated authentication May 26, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1625 (bfccce2) into main (73aa0da) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   71.39%   71.31%   -0.09%     
==========================================
  Files         296      295       -1     
  Lines       62146    61203     -943     
==========================================
- Hits        44370    43644     -726     
+ Misses      17776    17559     -217     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.86% <73.52%> (-0.05%) ⬇️
netfx 69.20% <75.60%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs 48.90% <0.00%> (-0.08%) ⬇️
...a.SqlClient/netcore/src/Resources/StringsHelper.cs 26.66% <ø> (ø)
...ient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs 58.29% <0.00%> (-0.08%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.61% <16.66%> (-0.90%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.59% <16.66%> (-0.38%) ⬇️
...lient/src/Microsoft/Data/SqlClient/SqlParameter.cs 75.50% <82.35%> (ø)
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs 68.49% <93.33%> (+0.92%) ⬆️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 72.57% <100.00%> (+0.37%) ⬆️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1996a...bfccce2. Read the comment docs.

Copy link
Contributor

@Kaur-Parminder Kaur-Parminder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SqlInternalConnectionTds and SqlUtil has a lot of new language version VS suggestions to apply.

@DavoudEshtehari
Copy link
Member Author

SqlInternalConnectionTds and SqlUtil has a lot of new language version VS suggestions to apply.
NIT: All methods including this in this class can use body expression. same for NetCore

They're a lot to improve, and if you check the possible merging codebases those are listed there. So, I'd rather don't mix them up with this change.

# Conflicts:
#	src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx
@DavoudEshtehari DavoudEshtehari merged commit 031afe8 into dotnet:main Jun 7, 2022
David-Engel added a commit to David-Engel/SqlClient that referenced this pull request Aug 5, 2022
David-Engel added a commit to David-Engel/SqlClient that referenced this pull request Aug 6, 2022
David-Engel added a commit that referenced this pull request Aug 9, 2022
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Aug 11, 2022
# Conflicts:
#	src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.Designer.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx
#	src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Aug 15, 2022
# Conflicts:
#	src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.Designer.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx
#	src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants