-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TDS8 version for TDSLogin #1657
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1657 +/- ##
==========================================
- Coverage 71.39% 71.32% -0.07%
==========================================
Files 293 293
Lines 61368 61382 +14
==========================================
- Hits 43812 43783 -29
- Misses 17556 17599 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also send the version in LOGIN7 (TdsLogin() method)?
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
Just a note that the minor version 0x0005 for SQL server 2022 would be changed to 0 in the next release SQL2022. |
for those who are going to test. Please use below query to see related fields. elect
ec.connect_time,es.last_request_start_time ,es.session_id,
(CAST(protocol_version AS BINARY(4))),
es.program_name, es.client_version, ec.protocol_type,ec.protocol_version,
es.client_interface_name,ec.encrypt_option
from sys.dm_exec_sessions as es
inner join sys.dm_exec_connections as ec
on ec.session_id = es.session_id |
This is addressing TDS8 issue with TDS Login version.
fixes #1652