Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Encoding UTF7 to ASCII for SSRP Broadcast #1671

Merged
merged 14 commits into from
Jul 21, 2022

Conversation

Kaur-Parminder
Copy link
Contributor

  • Changed the Encoding for SSRP Broadcast command to ASCII as it is used in other commands.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1671 (ecaf05e) into main (4e3aa5e) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
- Coverage   71.54%   71.42%   -0.13%     
==========================================
  Files         291      292       +1     
  Lines       61241    61272      +31     
==========================================
- Hits        43817    43765      -52     
- Misses      17424    17507      +83     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.97% <0.00%> (-0.12%) ⬇️
netfx 69.26% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/netcore/src/Microsoft/Data/SqlClient/SNI/SSRP.cs 52.59% <0.00%> (ø)
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 41.96% <0.00%> (-9.83%) ⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs 56.81% <0.00%> (-6.82%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
.../src/Microsoft/Data/SqlTypes/SqlTypeWorkarounds.cs 72.54% <0.00%> (-3.65%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 71.42% <0.00%> (-3.58%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 60.62% <0.00%> (-2.34%) ⬇️
...Client/Reliability/Common/SqlRetryLogicProvider.cs 89.13% <0.00%> (-2.18%) ⬇️
...Microsoft/Data/SqlClient/TdsParserStaticMethods.cs 72.22% <0.00%> (-1.12%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3aa5e...ecaf05e. Read the comment docs.

@DavoudEshtehari DavoudEshtehari added this to the 5.0.0 milestone Jul 13, 2022
@DavoudEshtehari DavoudEshtehari added the Area\Managed SNI Issues that are targeted to the Managed SNI codebase. label Jul 19, 2022
@DavoudEshtehari DavoudEshtehari merged commit 3a2b5fb into dotnet:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Managed SNI Issues that are targeted to the Managed SNI codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants