-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing Encoding UTF7 to ASCII for SSRP Broadcast #1671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kaur-Parminder
commented
Jul 13, 2022
- Changed the Encoding for SSRP Broadcast command to ASCII as it is used in other commands.
SNI Update
This reverts commit 7aebf45.
Codecov Report
@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
- Coverage 71.54% 71.42% -0.13%
==========================================
Files 291 292 +1
Lines 61241 61272 +31
==========================================
- Hits 43817 43765 -52
- Misses 17424 17507 +83
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SSRP.cs
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Jul 19, 2022
DavoudEshtehari
added
the
Area\Managed SNI
Issues that are targeted to the Managed SNI codebase.
label
Jul 19, 2022
JRahnama
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.