Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change | Using default system protocols for TDS8 on Managed code #1678

Conversation

JRahnama
Copy link
Contributor

This simple PR changes the previous behavior of the driver and omits using supported TLS protocols and uses the latest and the most secure TLS version on the client machine on managed code.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1678 (c0a1809) into main (4e3aa5e) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
- Coverage   71.54%   71.39%   -0.16%     
==========================================
  Files         291      293       +2     
  Lines       61241    61367     +126     
==========================================
- Hits        43817    43814       -3     
- Misses      17424    17553     +129     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.91% <ø> (-0.18%) ⬇️
netfx 69.27% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs 42.10% <ø> (+2.10%) ⬆️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 41.96% <0.00%> (-9.83%) ⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs 56.81% <0.00%> (-6.82%) ⬇️
...rc/Microsoft/Data/SqlClient/SQLFallbackDNSCache.cs 90.62% <0.00%> (-6.25%) ⬇️
.../src/Microsoft/Data/SqlTypes/SqlTypeWorkarounds.cs 71.42% <0.00%> (-4.77%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 71.42% <0.00%> (-3.58%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 60.62% <0.00%> (-2.34%) ⬇️
...Client/Reliability/Common/SqlRetryLogicProvider.cs 89.13% <0.00%> (-2.18%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3aa5e...c0a1809. Read the comment docs.

@DavoudEshtehari DavoudEshtehari added this to the 5.0.0 milestone Jul 22, 2022
@DavoudEshtehari DavoudEshtehari added 💡 Enhancement Issues that are feature requests for the drivers we maintain. Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. Area\Managed SNI Issues that are targeted to the Managed SNI codebase. and removed Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. labels Jul 22, 2022
@DavoudEshtehari DavoudEshtehari merged commit 13b8c7d into dotnet:main Jul 26, 2022
@JRahnama JRahnama deleted the fix-set-systemprotocol-to-true-strict-mode branch September 29, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Managed SNI Issues that are targeted to the Managed SNI codebase. 💡 Enhancement Issues that are feature requests for the drivers we maintain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants