Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.1] | Update SNI version #1795

Conversation

DavoudEshtehari
Copy link
Contributor

No description provided.

@DavoudEshtehari DavoudEshtehari added the Area\Native SNI Issues that are targeted to the Native SNI codebase. label Oct 7, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.0.1 milestone Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 65.47% // Head: 71.34% // Increases project coverage by +5.87% 🎉

Coverage data is based on head (40173d9) compared to base (914caf5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.0-servicing    #1795      +/-   ##
=================================================
+ Coverage          65.47%   71.34%   +5.87%     
=================================================
  Files                293      293              
  Lines              61385    61386       +1     
=================================================
+ Hits               40189    43797    +3608     
+ Misses             21196    17589    -3607     
Flag Coverage Δ
addons 92.38% <ø> (+92.38%) ⬆️
netcore 74.93% <100.00%> (+5.73%) ⬆️
netfx 69.20% <100.00%> (+5.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 72.84% <100.00%> (+1.47%) ⬆️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.50% <100.00%> (-0.15%) ⬇️
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 68.48% <100.00%> (+1.40%) ⬆️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.29% <100.00%> (-0.30%) ⬇️
...osoft/Data/SqlClient/SqlConnectionStringBuilder.cs 88.60% <100.00%> (+0.01%) ⬆️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-11.61%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@David-Engel David-Engel merged commit fd7f4f5 into dotnet:5.0-servicing Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Native SNI Issues that are targeted to the Native SNI codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants