Fix | TDS RPC error on large queries in SqlCommand.ExecuteReaderAsync #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the extra bytes written in TDS Packet during async reader
lcheunglci
changed the title
lcheunglci
changed the title
|
Looks like a simple fix to a hard to investigate problem. 👍 |
|
Indeed, the fix was simple but took a long time to get proper environment and repro case, and apparently it happened in all versions of Microsoft.Data.SqlClient including 1.0 but somehow was still working on System.Data.SqlClient. |
DavoudEshtehari
added
Area\Netfx
David-Engel
approved these changes
Mar 9, 2023
Kaur-Parminder
requested review from
JRahnama,
DavoudEshtehari and
Kaur-Parminder
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
- Coverage 70.82% 70.46% -0.36%
==========================================
Files 292 306 +14
Lines 61777 61563 -214
==========================================
- Hits 43752 43380 -372
- Misses 18025 18183 +158
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 54 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
DavoudEshtehari
approved these changes
Mar 20, 2023
lcheunglci
added a commit
to lcheunglci/SqlClient
that referenced
this pull request
Mar 23, 2023
lcheunglci
added a commit
to lcheunglci/SqlClient
that referenced
this pull request
Mar 30, 2023
lcheunglci
added a commit
to lcheunglci/SqlClient
that referenced
this pull request
Mar 30, 2023
lcheunglci
added a commit
to lcheunglci/SqlClient
that referenced
this pull request
Mar 31, 2023
This was referenced Apr 10, 2023
David-Engel
pushed a commit
that referenced
this pull request
Apr 10, 2023
David-Engel
pushed a commit
that referenced
this pull request
Apr 11, 2023
DavoudEshtehari
pushed a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found bug when using always encrypted with a large query with at least a parameter in async, it would insert extra bytes into the TDS packet header for the enclave byte per parameter when run in async mode resulting in the following error:
It turns out it was fixed in .NET Core but broken in .NET Framework, so after I backport changes i.e. move the logic of adding the enclave byte from once per parameter to once per rpc call, it seems to fix the issue.