Fix | Addressing the excepted behavior when error class is greater than 20 on retry connecting #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2023 01:57
JRahnama
requested review from
cheenamalhotra,
David-Engel,
lcheunglci,
DavoudEshtehari and
Kaur-Parminder
JRahnama
changed the title
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
- Coverage 71.53% 70.47% -1.06%
==========================================
Files 306 306
Lines 61841 61569 -272
==========================================
- Hits 44235 43390 -845
- Misses 17606 18179 +573
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 51 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Show resolved
Hide resolved
JRahnama
commented
Mar 23, 2023
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ExceptionTest/ConnectionExceptionTest.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
approved these changes
Mar 29, 2023
lcheunglci
reviewed
Mar 29, 2023
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Show resolved
Hide resolved
Co-authored-by: Lawrence Cheung <31262254+lcheunglci@users.noreply.github.com>
lcheunglci
approved these changes
Mar 29, 2023
Kaur-Parminder
approved these changes
Mar 29, 2023
kant2002
pushed a commit
to kant2002/SqlClient
that referenced
this pull request
Jun 29, 2023
…an 20 on retry connecting (dotnet#1953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1874