-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add | Adding support for net 7.0 #1981
Conversation
Since net8.0 is in preview, we have added support for net7.0 to be able to have access to some of new APIs.When Net8 is released net7.0 will be replaced with net8.0.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
==========================================
- Coverage 70.75% 69.92% -0.83%
==========================================
Files 306 306
Lines 61800 61805 +5
==========================================
- Hits 43724 43216 -508
- Misses 18076 18589 +513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@JRahnama nice to see this... Out of curiosity, which .NET 7.0 features are you specifically looking at? |
@roji, the goal is to be able to completely eliminate the SqlTypeWorkarounds.cs file for Net 8 and greater versions, but since Net 8 is still in preview stage we decided to go by Net7.0 for preview releases and when net8 GA version is released replace Net7.0 with Net8. |
once this is merged if you change the net8 to net7 in my PR #1934 then new paths should light up and remove the unneeded workarounds. |
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> Co-authored-by: David Engel <dengel1012@gmail.com>
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Since net8.0 is in preview, we have added support for net7.0 to be able to have access to some of new APIs.When Net8 is released net7.0 will be replaced with net8.0 for GA release.