Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add | Adding support for net 7.0 #1981

Merged
merged 6 commits into from
May 3, 2023

Conversation

JRahnama
Copy link
Contributor

Since net8.0 is in preview, we have added support for net7.0 to be able to have access to some of new APIs.When Net8 is released net7.0 will be replaced with net8.0 for GA release.

Since net8.0 is in preview, we have added support for net7.0 to be able to have access to some of new APIs.When Net8 is released net7.0 will be replaced with net8.0.
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.83 ⚠️

Comparison is base (4657311) 70.75% compared to head (d68aca5) 69.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1981      +/-   ##
==========================================
- Coverage   70.75%   69.92%   -0.83%     
==========================================
  Files         306      306              
  Lines       61800    61805       +5     
==========================================
- Hits        43724    43216     -508     
- Misses      18076    18589     +513     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.43% <ø> (-0.05%) ⬇️
netfx 68.12% <ø> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roji
Copy link
Member

roji commented Mar 31, 2023

@JRahnama nice to see this... Out of curiosity, which .NET 7.0 features are you specifically looking at?

@JRahnama
Copy link
Contributor Author

JRahnama commented Apr 1, 2023

@roji, the goal is to be able to completely eliminate the SqlTypeWorkarounds.cs file for Net 8 and greater versions, but since Net 8 is still in preview stage we decided to go by Net7.0 for preview releases and when net8 GA version is released replace Net7.0 with Net8.

@Wraith2
Copy link
Contributor

Wraith2 commented Apr 3, 2023

once this is merged if you change the net8 to net7 in my PR #1934 then new paths should light up and remove the unneeded workarounds.

@David-Engel David-Engel added this to the 5.2.0-preview2 milestone Apr 25, 2023
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Co-authored-by: David Engel <dengel1012@gmail.com>
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@DavoudEshtehari DavoudEshtehari added the Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. label May 2, 2023
@JRahnama JRahnama requested a review from David-Engel May 3, 2023 19:57
@JRahnama JRahnama added Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. and removed Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. labels May 3, 2023
@JRahnama JRahnama merged commit cbdf41c into dotnet:main May 3, 2023
@JRahnama JRahnama changed the title Adding support for net 7.0 Add | Adding support for net 7.0 Jun 7, 2023
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
@JRahnama JRahnama deleted the adding-net7.0-support branch September 8, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants