Fix | Adding non-string support to SqlConnectionStringBuilder property indexer #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
==========================================
+ Coverage 70.02% 70.63% +0.61%
==========================================
Files 306 306
Lines 61800 61805 +5
==========================================
+ Hits 43275 43657 +382
+ Misses 18525 18148 -377
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Possible to add a test? |
Sure, I will add some tests here. Tests are added. |
JRahnama
changed the title
David-Engel
reviewed
Apr 25, 2023
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionEncryptOption.xml
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOption.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOption.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <dengel1012@gmail.com>
David-Engel
approved these changes
Apr 26, 2023
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
DavoudEshtehari
approved these changes
Apr 28, 2023
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs
Show resolved
Hide resolved
kant2002
pushed a commit
to kant2002/SqlClient
that referenced
this pull request
Jun 29, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 25, 2023
…ionStringBuilder property indexer Ports [dotnet#2018](dotnet#2018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2015