-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | SqlBuffer.SqlGuid #2310
Fix | SqlBuffer.SqlGuid #2310
Conversation
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBuffer.cs
Outdated
Show resolved
Hide resolved
Because the revert PR #2311 is merged, I will replace this PR's commits with functional tests for |
bc5d796
to
ebf0c88
Compare
after SetToNullOfType(StorageType.Guid) is invoked
after SetToNullOfType(StorageType.Guid) is invoked
ebf0c88
to
be27257
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
==========================================
+ Coverage 72.47% 72.61% +0.13%
==========================================
Files 310 310
Lines 61873 61877 +4
==========================================
+ Hits 44845 44930 +85
+ Misses 17028 16947 -81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hmm, I don't get what it actually failed in the tests =\ |
@wilbit No need to worry; this seems to be a random Azure resource issue. |
Any feedback about the PR? |
Anything? |
This will be reviewed for the next preview release. We are on code freeze now for the GA release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, real life stuff happened.
May we merge this PR? |
Bug description:
SqlBuffer.get_SqlGuid
could returnSqlGuid
with incorrect (or empty)Guid
value inside afterSqlBuffer.SetToNullOfType(StorageType.Guid)
is invoked.