Merge common code base for SqlUtil.cs #2503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
==========================================
+ Coverage 72.72% 72.97% +0.24%
==========================================
Files 313 310 -3
Lines 61718 61062 -656
==========================================
- Hits 44886 44560 -326
+ Misses 16832 16502 -330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arellegue
assigned David-Engel, JRahnama, DavoudEshtehari and dauinsight and unassigned David-Engel, JRahnama, DavoudEshtehari and dauinsight
arellegue
requested review from
David-Engel,
JRahnama,
DavoudEshtehari and
dauinsight
David-Engel
reviewed
May 16, 2024
| @@ -550,7 +553,7 @@ | |||
| </Compile> | |||
| <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlUtil.cs"> | |||
| <Link>Microsoft\Data\SqlClient\SqlUtil.cs</Link> | |||
| </Compile> | |||
| </Compile> | |||
There was a problem hiding this comment.
Suggested change
| </Compile> | |
| </Compile> |
| @@ -581,7 +584,7 @@ | |||
| </Compile> | |||
| <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlUtil.cs"> | |||
| <Link>Microsoft\Data\SqlClient\SqlUtil.cs</Link> | |||
| </Compile> | |||
| </Compile> | |||
There was a problem hiding this comment.
Suggested change
| </Compile> | |
| </Compile> |
| internal static Exception SynchronousCallMayNotPend() | ||
| { | ||
| return new Exception(StringsHelper.GetString(Strings.Sql_InternalError)); | ||
| } | ||
|
|
||
| #if NETCOREAPP |
There was a problem hiding this comment.
Recent PR #2486 streamlined compilation symbols. You should pull from main and then update this.
Suggested change
| #if NETCOREAPP | |
| #if NET6_0_OR_GREATER |
DavoudEshtehari
added
the
➕ Code Health
DavoudEshtehari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses SqlUtil.cs for #1261