Skip to content

Fix | TvpTest Split Phase 5 #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arellegue
Copy link
Contributor

Created unit test for SendAllSqlTypesInsideVariantTest.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 42.71186% with 507 lines in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (348ae2e) to head (78ff5c6).
Report is 13 commits behind head on main.

Current head 78ff5c6 differs from pull request most recent head d7c57e2

Please upload reports for the commit d7c57e2 to get more accurate results.

Files Patch % Lines
...rc/Microsoft/Data/SqlClient/SqlClientDiagnostic.cs 20.12% 381 Missing ⚠️
...SqlClient/SqlClientDiagnosticListenerExtensions.cs 54.44% 82 Missing ⚠️
...SqlClient/ActiveDirectoryAuthenticationProvider.cs 78.00% 22 Missing ⚠️
...icrosoft/Data/SqlClient/SqlDelegatedTransaction.cs 61.53% 5 Missing ⚠️
...rc/Microsoft/Data/SqlClient/SqlConnectionHelper.cs 25.00% 3 Missing ⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionSmi.cs 0.00% 3 Missing ⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 50.00% 3 Missing ⚠️
...crosoft/Data/SqlClient/SSPI/SSPIContextProvider.cs 50.00% 3 Missing ⚠️
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs 81.81% 2 Missing ⚠️
.../Microsoft/Data/SqlClient/SqlQueryMetadataCache.cs 81.81% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   73.01%   72.59%   -0.42%     
==========================================
  Files         311      310       -1     
  Lines       61694    61688       -6     
==========================================
- Hits        45043    44785     -258     
- Misses      16651    16903     +252     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.44% <41.47%> (-0.91%) ⬇️
netfx 70.49% <79.43%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arellegue arellegue marked this pull request as ready for review June 18, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant