Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlBulkCopy support for JSON datatype #2916

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

apoorvdeshmukh
Copy link
Contributor

This PR adds SqlBulkCopy support for for JSON datatype.
It supports streaming as well for multibyte characters.
A new testcase JsonBulkCopyTest has been introduced to test changes with CommandBehavior Default and SequentialAccess and with EnableStreaming set and unset.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (2f0de19) to head (32df131).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 26.31% 14 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 26.31% 14 Missing ⚠️
...etcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs 80.00% 1 Missing ⚠️
.../netfx/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2916      +/-   ##
==========================================
- Coverage   71.88%   71.83%   -0.05%     
==========================================
  Files         294      294              
  Lines       60253    60287      +34     
==========================================
- Hits        43311    43310       -1     
- Misses      16942    16977      +35     
Flag Coverage Δ
addons 92.90% <ø> (ø)
netcore 75.77% <37.50%> (-0.04%) ⬇️
netfx 70.39% <37.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saurabh500 saurabh500 added this to the 6.0-preview2 milestone Oct 15, 2024
@apoorvdeshmukh apoorvdeshmukh merged commit cbfa119 into dotnet:main Oct 16, 2024
130 checks passed
@mdaigle mdaigle added the Area\Json Issues that are targeted for the Json feature in the driver. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Json Issues that are targeted for the Json feature in the driver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants