-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move relative to absolute docs path #2949
Move relative to absolute docs path #2949
Conversation
Thank you for your contribution to this! I'm glad someone was keen enough to take on this annoying task! I'm going to have to look into this a little bit before signing off on it. According to @cheenamalhotra, we get warnings from [something] when absolute links are used. So it's an unfortunate situation where if we use relative links, the links don't work in IDEs but the doc websites are happy, and vice versa if we use absolute links. |
Sure, let me know where you see the error and I can also look for creative workarounds ;) |
Tbh, I'm not sure exactly where this error comes in. My assumption is that it comes from our doc website generation process, but I don't know what that is. Need @cheenamalhotra's input on that |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
I believe we will get warnings in .NET API reference, when the docs will be published. Something we should follow up internally, if this will be allowed with the .NET API reference docs team, because the XML files are the same that are published to both VS intellisense and .NET API reference Microsoft documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One broken link, otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dotnet framework links are obsolete, and don't apply to Microsoft.Data.SqlClient documentation. Use sql/connect/ado-net instead.
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Malcolm Daigle <daiglemalcolm@gmail.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Moving relative links to learn.microsoft.com, also verify msdn/docs .microsoft.com links and replacing them with learn.microsoft.com.
.xml Documentation files only
Fixes #2883