Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Health | Remove unused/unreferenced files #3008

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

edwardneal
Copy link
Contributor

This is largely cleanup from earlier PRs - four files are no longer used:

  • SqlTypeWorkarounds.netcore.cs: no longer referenced as a result of the removal of .NET 6.0 support
  • ApplicationProtocolNegotiationExt.netcore.cs: see above
  • ApplicationProtocolNegotiationStatus.netcore.cs: see above
  • SqlFileStream.cs: this is the netfx version. No longer referenced in the csproj, it was just left behind when SqlFileStream was merged

Not essential for preview3, although I don't see it having any impact if included (beyond review time!)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (5744b51) to head (9c64f17).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
+ Coverage   72.45%   72.47%   +0.02%     
==========================================
  Files         288      287       -1     
  Lines       59493    59474      -19     
==========================================
+ Hits        43104    43106       +2     
+ Misses      16389    16368      -21     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.41% <ø> (+0.03%) ⬆️
netfx 70.91% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 added Common Project 🚮 Things that relate to the common project project ➕ Code Health Issues/PRs that are targeted to source code quality improvements. labels Nov 15, 2024
@benrr101 benrr101 added this to the 6.0-preview3 milestone Nov 15, 2024
@cheenamalhotra cheenamalhotra merged commit d8b6ca7 into dotnet:main Nov 15, 2024
76 checks passed
@edwardneal edwardneal deleted the netcore-sqltypes-cleanup branch November 15, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project ➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants