Fix | Remove TargetFramework From ExtUtilities Project #3178
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory.build.props
benrr101
added
🐛 Bug!
Area\Tests
cheenamalhotra
approved these changes
Feb 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
=======================================
Coverage 72.81% 72.82%
=======================================
Files 282 282
Lines 59112 59112
=======================================
+ Hits 43045 43050 +5
+ Misses 16067 16062 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
paulmedynski
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: I spent far too long trying to track down completely unrelated errors that were resolved by this. The Directory.Build.props file two directories up includes definitions for TargetFrameworks, as well as in the ExtUtilities project. So when attempting certain builds from the IDE, it will throw errors that net9.0 is specified >1 and refuse to build. Removing the line in the csproj file resolves the issue.
Testing: Local builds are working again, will wait to see if it causes CI issues.