Skip to content

Improve <LangVersion> selection #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Improve <LangVersion> selection #3240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e834324
User Story 33639: Remove <LangVersion> from build config
paulmedynski Mar 24, 2025
38b2cb3
User Story 33639: Remove <LangVersion> from build config
paulmedynski Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<LangVersion>9.0</LangVersion>
<TargetsWindows Condition="'$(OS)' == 'Windows_NT' AND '$(OSGroup)' == ''">true</TargetsWindows>
<TargetsWindows Condition="'$(OS)' != 'Windows_NT' AND '$(OSGroup)' == ''">false</TargetsWindows>
<TargetsWindows Condition="'$(OSGroup)' == 'Windows_NT'">true</TargetsWindows>
Expand Down Expand Up @@ -111,4 +110,25 @@
<PropertyGroup>
<AddSyntheticProjectReferencesForSolutionDependencies>false</AddSyntheticProjectReferencesForSolutionDependencies>
</PropertyGroup>

<!--
For non-.NET, we explicitly set the C# language version to 13. This matches
the language version used by the .NET 9 SDK, and provides helpful modern
language features. While this isn't strictly supported by .NET in general,
it works well in practice. There are very few C# language features that
depend on SDK APIs, and we avoid them.

For .NET, we omit this property entirely, which results in the SDK choosing
the C# language version that matches the .NET version.

Details here:

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/language-versioning

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version
-->
<PropertyGroup
Condition="'$([MSBuild]::GetTargetFrameworkIdentifier($(TargetFramework)))' != '.NETCoreApp'">
<LangVersion>13.0</LangVersion>
</PropertyGroup>
</Project>
Loading