-
Notifications
You must be signed in to change notification settings - Fork 317
ESRP federated credential update (move to AME) #3261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmedynski
approved these changes
Apr 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 298 297 -1
Lines 59675 59661 -14
=======================================
- Hits 43463 43454 -9
+ Misses 16212 16207 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Apr 9, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 9, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 9, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 9, 2025
This was referenced Apr 9, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 10, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 11, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will be backported to all in-support branches.
Removed all hard-coded, duplicated variables to follow single variable group for ESRP configuration values.